...
Some useful information is summarized in the check list below.
Check list:
- Coding Style
- Go over the Floodlight coding style guide and make sure all your code adheres to these guidelinesMake your code as readable as possible, please. Please match the existing style.
- Testing
- Unit Tests
- If you have added new functionality please make sure that appropriate unit tests have been added.
- If you have modified existing functionality please make sure the existing tests pass.
- If you have fixed a bug please make sure to write a unit test so it doesn't happen in regression.
- All tests must be passing before we can accept the code.
- Integration Tests
- For any medium to large size project an integration test is required.
- Integration tests must be written using the Floodlight-Test framework.
- If you modify functionality that affects existing tests those must be modified to match the new functionality.
- Unit Tests
- Submitting the code
- Update your git repository to the latest floodlight master branch:
- under your floodlight source diretory, do 'git pull upstream master' (assuming you have configured upstream to be the floodlight/floodlight repo)
- If applicable, resolve any merge conflicts.
- Create a pull request to the floodlight/floodlight project on GitHub.
- If you're code needs extra integration, an administrator of the Floodlight project may ask you to submit a pull request to their private fork instead.
- If you would like community feedback on your patch, email the Floodlight mailing list with a link to the pull request and ask for feedback.
- Intellectual Property
- Review the Developer Grant and Certificate of Origin.
- In your pull request you must include the text "Floodlight-DCO-1.0-Signed-off-by: Joe Smith <your@email.com>" with your real name and email.
- Update your git repository to the latest floodlight master branch: